Add header to target containing the sequence number #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
commented
Jan 19, 2020
tsenart
requested changes
Jan 19, 2020
|
Ping @jackdbernier |
|
I’m planning on coming back to this. I’m currently on vacation so it might
take a few weeks.
…On Sat, Feb 8, 2020 at 11:37 PM Tomás Senart ***@***.***> wrote:
Ping @jackdbernier <https://github.com/jackdbernier>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#470?email_source=notifications&email_token=AAE46KBH4WOEO6SZNIZ6KB3RB2DQDA5CNFSM4KIXBS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFO4QY#issuecomment-583724611>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE46KAINDIZQA7CA2CKRXLRB2DQDANCNFSM4KIXBS2A>
.
|
tsenart
approved these changes
Feb 16, 2020
|
Awesome! Thank you so much.
I will take a look at it when I get back to work.
…On Mon, Feb 17, 2020 at 12:57 AM Tomás Senart ***@***.***> wrote:
Merged #470 <#470> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#470?email_source=notifications&email_token=AAE46KBYJ3VTPPKDTKMBDZLRDESZHA5CNFSM4KIXBS2KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWVE3CSA#event-3041505608>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE46KATZIHAEM2N2OEGGULRDESZHANCNFSM4KIXBS2A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Following up the discussion here #462
This adds the res.Seq to the target headers with the name "X-Vegeta-Seq".
This also add a new unit test to check that the header is equal to the res.Seq.
Checklist